Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a memory benchmark for watcher #1505

Open
clux opened this issue May 29, 2024 · 1 comment
Open

Create a memory benchmark for watcher #1505

clux opened this issue May 29, 2024 · 1 comment
Labels
automation ci and testing related help wanted Not immediately prioritised, please help!

Comments

@clux
Copy link
Member

clux commented May 29, 2024

What problem are you trying to solve?

Would like to know if a PR improves/degrades the memory profile of a watcher significantly.
We can't rely on people producing such excellent manual benchmarks such as in #1494.

Describe the solution you'd like

Not sure if this would work so take this with a grain of salt. Any practical suggestions would be considered.

Describe alternatives you've considered

Have only really skimmed https://nnethercote.github.io/perf-book/profiling.html
I'm sure there are better solutions.

Target crate for feature

kube-runtime

@clux clux added help wanted Not immediately prioritised, please help! automation ci and testing related labels May 29, 2024
@clux
Copy link
Member Author

clux commented Jun 13, 2024

Case-in-point: the buffer follow-up in #1504 making individual pages in watcher held as a slowly draining VecDeque may actually have undone a portion of the memory improvements in the original PR, but I only e2e tested one controller case at the time.

You can still get the gains by lowering the page_size (as noted in the results section of the 0.92 blog post), or using streaming lists, so am still happy with the state of things (got both ergonomic improvements and big memory gains). But it was just one of those unwelcome surprises that made me doubt myself quite a bit yesterday when going over the benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation ci and testing related help wanted Not immediately prioritised, please help!
Projects
None yet
Development

No branches or pull requests

1 participant