Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"All Drafts" mode: all comments are drafts before completing review. #54

Open
klikh opened this issue Aug 12, 2013 · 1 comment
Open

Comments

@klikh
Copy link
Collaborator

klikh commented Aug 12, 2013

This mode can be useful for the following use case:
I review some large commit, and once I see something not clear or suspicious, I make a comment. However, since I haven't inspected the whole commit yet, I just can not get the logic because I don't see the whole picture yet. After I see all changed code, I understand, that the code is correct, and my comment becomes obsolete.

However, the author has already received a notification about my comment. He might have already spent time to answer the comment providing the information which I could recover myself.

Therefore it would be useful to mark all comments as drafts by defalt, and propose to "commit" them when user clicks "Complete".

@klikh
Copy link
Collaborator Author

klikh commented Aug 18, 2013

Since #51 is implemented, there is no more need in any special mode for drafts: just write comments, but close popups via Esc, and they all will be saved as drafts.
To implement this feature we just need to propose to publish all drafts when "Complete review" button is clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant