fix: Fix not reading limits when cgroup v2 used #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckadner
force-pushed
the
fix-cgroupv2
branch
from
d6d40f4 to
b6aa21e
Compare
ckadner
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Thank you @funbiscuit -- The change looks good. Could you please fix the DCO check, sign-off your commits?
https://github.com/kserve/modelmesh/pull/107/checks?check_run_id=17237005674
Signed-off-by: funbiscuit <[email protected]>
funbiscuit
force-pushed
the
fix-cgroupv2
branch
from
b6aa21e to
b10ca83
Compare
|
@ckadner I've updated commit message, now DCO passes. |
ckadner
approved these changes
Sep 29, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, funbiscuit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Docker image was not picking up memory limits when cgroup v2 was used. This lead to incorrect java heap memory limits that lead to crashes due to OOMKilled as described in #106
Modifications
To
start.shscript that launches application added extra check for limits in cgroup v2 file.Result
Docker image works and correctly reads memory limits with both cgroup v1 and v2.