Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change release process to update KServe Helm charts based on kustomize build dry-run #447

Open
ckadner opened this issue Oct 10, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ckadner
Copy link
Member

ckadner commented Oct 10, 2023

Describe the problem

Currently, we update the KServe Helm charts for ModelMesh with each release in a rather tedious manual process, where we find all the changes made to the ModelMesh Serving kustomize manifests in the kserve/modelmesh-serving repo and update the corresponding Helm charts in the kserve/kserve repo.

However, the ModelMesh manifests are modified during the install process before being deployed to the cluster. Yet, we usually update the KServe Helm charts based on the unmodified YAML files in the config/ folder. Which means there are differences in an actual ModelMesh Serving deployment when installed using the ModelMesh Serving install script, vs the ModelMesh Serving deployment installed via the KServe Helm charts.

Proposed solution

We need to update the ModelMesh Serving release process to run a kustomize build (run the install script in dry-run mode) and use the generated final manifests as the basis to sync with the Helm charts in the kserve/kserve repo.

FYI @rafvasq @Jooho @rachitchauhan43

@ckadner ckadner added bug Something isn't working help wanted Extra attention is needed labels Oct 10, 2023
@spolloni
Copy link

spolloni commented Aug 2, 2024

Hey @ckadner! I landed on this issue while trying to decide how to install model mesh. I am very ignorant about kerserve and modelmesh at this stage -- trying to experiment with it for the first time. I do have a penchant for the helm charts though as this is how we install most things in our cluster.

there are differences in an actual ModelMesh Serving deployment when installed using the ModelMesh Serving install script, vs the ModelMesh Serving deployment installed via the KServe Helm charts.

should I worry about these differences in any way?

@spolloni
Copy link

spolloni commented Aug 2, 2024

it also seems the latest version in the chart is 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants