Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve KMS service configuration #9

Open
robobario opened this issue Jul 3, 2023 · 0 comments
Open

Improve KMS service configuration #9

robobario opened this issue Jul 3, 2023 · 0 comments

Comments

@robobario
Copy link

robobario commented Jul 3, 2023

          Can we make this an actual issue please?

Originally posted by @SamBarker in #7 (comment)

In this branch I wanted to create a MockKms with a map from key reference to key. We are limited to a couple of Strings at the moment on the KmsDefinition:

    private String instanceId; // optional. IBM Cloud requires this
    private String credential;

So to configure in the map, I abused the credential field to pass in a CSV to build the map.

Maybe topic-encryption could pinch the Kroxylicious Contributor API so each KMS type could optionally define it's own custom configuration class that would be constructed and wired into the constructor.

Or it could support a Map<String, Object> of generic configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant