Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Antialiasing on webgl2 panics #471

Closed
kpreid opened this issue Feb 18, 2024 · 2 comments
Closed

Antialiasing on webgl2 panics #471

kpreid opened this issue Feb 18, 2024 · 2 comments
Labels
area: graphics kind: bug Something isn't working as it should WebGL Affects rendering using WebGL only

Comments

@kpreid
Copy link
Owner

kpreid commented Feb 18, 2024

Enabling the antialiasing graphics option, on web, will panic. Filed wgpu issue about the panic: gfx-rs/wgpu#5263. However, If I understand correctly,

  • the problem is using a multisampled texture as an input to a shader, and
  • the fix for that issue will be disabling the ability to do so (without a DownlevelFlags that the wgpu webgl backend won't support), not making it work.

Therefore, we need to make antialiasing and bloom (or whatever features are actually conflicting) mutually exclusive on web.
@kpreid kpreid added kind: bug Something isn't working as it should area: graphics labels Feb 18, 2024
@kpreid
Copy link
Owner Author

kpreid commented Jul 18, 2024 •
edited
Loading

Testing: this bug is not fixed by wgpu 22.0.0.

kpreid added a commit that referenced this issue Feb 25, 2025
@kpreid
gpu: Workaround WebGL bug by disabling antialiasing.
192227e 
See <#471> and
<gfx-rs/wgpu#5263>. Based on the latest
information, I expect this will not start working any time soon, so add
a condition to disable antialiasing. Conveniently, we already had the
`rgba8_can_multisample` flag to communicate this, though it wasn’t
actually used where it should be.

I believe it might be possible to also keep antialiasing but disable all
screen-space processing (including tone mapping), but I don’t like that
option.
@kpreid
Copy link
Owner Author

kpreid commented Feb 25, 2025

Commit 192227e adds code to automatically disable antialiasing. I think this is likely the best we’re going to get any time soon, so I’m closing this issue.

@kpreid kpreid closed this as completed Feb 25, 2025
@kpreid kpreid added the WebGL Affects rendering using WebGL only label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: graphics kind: bug Something isn't working as it should WebGL Affects rendering using WebGL only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpreid