Skip to content

Commit 5016947

Browse files
committed
modified example, updated version number
1 parent 575f962 commit 5016947

5 files changed

Lines changed: 29 additions & 14 deletions

File tree

FtpLibrary.html

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

FtpLibrary.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,10 @@ class FtpLibrary(object):
2626
"""
2727
This library provides functionality of FTP client.
2828
29-
Version 1.8 released on 30th of December 2019
29+
Version 1.9 released on 27th of February 2020
3030
31-
What's new in release 1.8:
32-
- TLS support by Antonpaa
33-
- one bugfix by Jarkko Peltonen
31+
What's new in release 1.9:
32+
- active mode added by Alexander Klose (scathaig)
3433
3534
FTP communication provided by ftplib.py
3635

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,11 @@ What's new in release 1.8:
4444
- TLS support by Antonpaa
4545
- one bugfix by Jarkko Peltonen
4646

47+
Version 1.9 released on 27th of February 2020
48+
49+
What's new in release 1.9:
50+
- active mode added by Alexander Klose (scathaig)
51+
4752
## Installation
4853
- run command: **pip install robotframework-ftplibrary**
4954

ftpLibraryExample.robot

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ the_simplest_example_public_ftp
2222
public example
2323

2424
the_simplest_example_public_ftp_looped
25-
: FOR ${i} IN RANGE 0 3
26-
\ public example
25+
FOR ${i} IN RANGE 0 3
26+
public example
2727

2828
get_connections
2929
[Documentation] Testing new keyword "get all ftp connections"
@@ -34,10 +34,10 @@ get_connections
3434
${connections}= get all ftp connections
3535
@{connectionKeys}= get dictionary keys ${connections}
3636
@{connectionValues}= get dictionary values ${connections}
37-
: FOR ${k} IN @{connectionKeys}
38-
\ Log ${k}
39-
: FOR ${c} IN @{connectionValues}
40-
\ Log ${c}
37+
FOR ${k} IN @{connectionKeys}
38+
Log ${k}
39+
FOR ${c} IN @{connectionValues}
40+
Log ${c}
4141
ftp close
4242
ftp close secondConn
4343
ftp close thirdConn
@@ -98,8 +98,7 @@ negative_tests
9898
ftp connect ${local_ftp_addr_1} ${user_1} ${pass_1} connId=newConn
9999
${passed}= Run Keyword And Return Status pwd connId=newConn2
100100
Run Keyword Unless ${passed} Log Fail as expected
101-
${passed2}= Run Keyword And Return Status ftp connect ${local_ftp_addr_1} ${user_1} ${pass_1} connId=newConn
102-
... # already existing connection ID
101+
${passed2}= Run Keyword And Return Status ftp connect ${local_ftp_addr_1} ${user_1} ${pass_1} connId=newConn # already existing connection ID
103102
Run Keyword Unless ${passed2} Log Fail as expected
104103
${passed3}= Run Keyword And Return Status pwd connId=newConn8 # not existing connection ID
105104
Run Keyword Unless ${passed3} Log Fail as expected
@@ -114,6 +113,18 @@ tls keywords check with non tls connection
114113
Secure Data Connection
115114
ftp close
116115

116+
the_simplest_example_public_ftp_active_mode
117+
comment Public FTP server IP address taken from http://stackoverflow.com/questions/7968703/is-there-a-public-ftp-server-to-test-upload-and-download
118+
Log Example does not work because server seems not to accept active mode WARN
119+
ftp connect ${public_address} mode=active
120+
@{dirResult}= dir
121+
Log ${dirResult}
122+
@{files}= dir names
123+
Log ${files}
124+
${pwdMsg}= pwd
125+
download file ${public_file_name}
126+
ftp close
127+
117128
*** Keywords ***
118129
public_example
119130
comment Public FTP server IP address taken from http://stackoverflow.com/questions/7968703/is-there-a-public-ftp-server-to-test-upload-and-download

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from distutils.core import setup
2525

2626
setup(name='robotframework-ftplibrary',
27-
version='1.8',
27+
version='1.9',
2828
description='Robot Framework Ftp Library',
2929
author='Marcin Kowalczyk',
3030
license='GPLv3',

0 commit comments

Comments
 (0)