Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit breaker never closes when permittedCallsInHalfOpenState is less than minimumRequiredCalls #246

Open
baranchikovaleks opened this issue Feb 11, 2025 · 1 comment · May be fixed by #256
Assignees
Labels
module: resilient Related to Resilient module
Milestone

Comments

@baranchikovaleks
Copy link

Hey there!

We've faced a problem that CB cannot have CLOSED state when permittedCallsInHalfOpenState is less than minimumRequiredCalls, because after reaching permittedCallsInHalfOpenState it switches to OPEN again that is an endless loop.

Even though this behaviour is pretty straight forward from properties description, the docs encourages this in the examples here https://kora-projects.github.io/kora-docs/en/documentation/resilient/#configuration

@GoodforGod GoodforGod added bug Something isn't working module: resilient Related to Resilient module labels Feb 13, 2025
@GoodforGod GoodforGod added this to the 1.1.20 milestone Feb 13, 2025
@GoodforGod GoodforGod removed the bug Something isn't working label Feb 13, 2025
@GoodforGod
Copy link
Contributor

Prob need to add check when CB is constructored for this case

@GoodforGod GoodforGod modified the milestones: v1.1.20, v1.1.21 Feb 28, 2025
@GoodforGod GoodforGod linked a pull request Feb 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: resilient Related to Resilient module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants