Add metrics to controllers tracking reconciliations #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
force-pushed
the
add-prom-metrics
branch
from
9295be2
to
bb8563a
Compare
update changelog
mh013370
force-pushed
the
add-prom-metrics
branch
from
bb8563a
to
a9704cf
Compare
|
I just need to deploy this and verify the metrics are getting set correctly, but this is ready for review. |
Confirmed that these metrics are now reported by nifikop: root ➜ /workspace $ curl localhost:8080/metrics|grep nifikop
# HELP nifikop_operator_ready 1 when the controller is ready to reconcile resources, 0 otherwise
# TYPE nifikop_operator_ready gauge
nifikop_operator_ready{controller="NifiCluster"} 1
nifikop_operator_ready{controller="NifiClusterTask"} 1
nifikop_operator_ready{controller="NifiDataflow"} 1
nifikop_operator_ready{controller="NifiNodeGroupAutoscaler"} 1
nifikop_operator_ready{controller="NifiParameterContext"} 1
nifikop_operator_ready{controller="NifiRegistryClient"} 1
nifikop_operator_ready{controller="NifiUser"} 1
nifikop_operator_ready{controller="NifiUserGroup"} 1
# HELP nifikop_operator_reconcile_duration_seconds Histogram of reconcile operations
# TYPE nifikop_operator_reconcile_duration_seconds histogram
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiCluster",le="0.1"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiCluster",le="0.5"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiCluster",le="1"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiCluster",le="5"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiCluster",le="10"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiCluster",le="+Inf"} 0
nifikop_operator_reconcile_duration_seconds_sum{controller="NifiCluster"} 0
nifikop_operator_reconcile_duration_seconds_count{controller="NifiCluster"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiClusterTask",le="0.1"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiClusterTask",le="0.5"} 0
........
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiUserGroup",le="10"} 0
nifikop_operator_reconcile_duration_seconds_bucket{controller="NifiUserGroup",le="+Inf"} 0
nifikop_operator_reconcile_duration_seconds_sum{controller="NifiUserGroup"} 0
nifikop_operator_reconcile_duration_seconds_count{controller="NifiUserGroup"} 0
# HELP nifikop_operator_reconcile_errors_total Number of errors that occurred during reconcile operations
# TYPE nifikop_operator_reconcile_errors_total counter
nifikop_operator_reconcile_errors_total{controller="NifiCluster"} 0
nifikop_operator_reconcile_errors_total{controller="NifiClusterTask"} 0
nifikop_operator_reconcile_errors_total{controller="NifiDataflow"} 0
nifikop_operator_reconcile_errors_total{controller="NifiNodeGroupAutoscaler"} 0
nifikop_operator_reconcile_errors_total{controller="NifiParameterContext"} 0
nifikop_operator_reconcile_errors_total{controller="NifiRegistryClient"} 0
nifikop_operator_reconcile_errors_total{controller="NifiUser"} 0
nifikop_operator_reconcile_errors_total{controller="NifiUserGroup"} 0
# HELP nifikop_operator_reconcile_operations_total Total number of reconcile operations
# TYPE nifikop_operator_reconcile_operations_total counter
nifikop_operator_reconcile_operations_total{controller="NifiCluster"} 0
nifikop_operator_reconcile_operations_total{controller="NifiClusterTask"} 0
nifikop_operator_reconcile_operations_total{controller="NifiDataflow"} 0
nifikop_operator_reconcile_operations_total{controller="NifiNodeGroupAutoscaler"} 0
nifikop_operator_reconcile_operations_total{controller="NifiParameterContext"} 0
nifikop_operator_reconcile_operations_total{controller="NifiRegistryClient"} 0
nifikop_operator_reconcile_operations_total{controller="NifiUser"} 0
nifikop_operator_reconcile_operations_total{controller="NifiUserGroup"} 0 |
|
I've just realized that almost all of these metrics are already provided by the controller runtime. I'm going to close this PR and re-scope the ticket. We might still be able to add metrics capturing how many of the CRDs the operator is watching, but that will be a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
I've added prometheus metrics capturing all of the following:
Why?
To improve observability of the nifikop operator
Checklist