Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warning is_tiledlayout is deprecated #101

Open
vmiheer opened this issue May 23, 2024 · 3 comments
Open

Compiler warning is_tiledlayout is deprecated #101

vmiheer opened this issue May 23, 2024 · 3 comments
Assignees

Comments

@vmiheer
Copy link
Contributor

vmiheer commented May 23, 2024

I found kokkos/kokkos#6907 but I am not https://github.com/vmiheer/kokkos-remote-spaces/blob/56c3f9c07f2e7a05f76c939cbc2a08ba9b27f267/src/core/Kokkos_RemoteSpaces_DeepCopy.hpp#L580 and the deprecation notice does not specify the alternative.

I stumbled upon it trying to understand KRS + MPI build failure. This warning doesn't cause build failure but there is something in benchmarks/applications is causing it.

@janciesko
Copy link
Contributor

Thanks, yes, I did notice this but was not able to get back to it timely. I should have a fix for this shortly.

@janciesko janciesko self-assigned this May 28, 2024
@janciesko
Copy link
Contributor

#102 should fix those issues.

@dalg24
Copy link
Member

dalg24 commented May 28, 2024

#102 should fix those issues.

Mixing unrelated things into the same PR makes it difficult to audit changes. You should consider dedicate a PR to getting rid of code that was using is_tiledlayout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants