Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test headers are installed #2332

Open
tpadioleau opened this issue Sep 10, 2024 · 2 comments · May be fixed by #2334
Open

Unit test headers are installed #2332

tpadioleau opened this issue Sep 10, 2024 · 2 comments · May be fixed by #2334

Comments

@tpadioleau
Copy link
Member

Hi,

I noticed that headers from some unit_test directories are installed. I suspect it is a mistake ?

The command grep -R "APPEND KK_INCLUDE_DIRS .*unit_test" from the top-level directory returns:

common/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/common/unit_test)
ode/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/ode/unit_test)
batched/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/batched/dense/unit_test)
batched/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/batched/sparse/unit_test)
@lucbv
Copy link
Contributor

lucbv commented Sep 10, 2024

Okay, thanks for reporting this @tpadioleau
I suspect we rarely install the library ourselves so we did not notice, if you want to create a PR with these changes that would be kind!

@tpadioleau
Copy link
Member Author

Yes i will have a deeper look.

@tpadioleau tpadioleau linked a pull request Sep 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants