Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Binance] New API call DustLog not available in XChange #4371

Open
gregoreficint opened this issue Dec 24, 2021 · 0 comments
Open

[Binance] New API call DustLog not available in XChange #4371

gregoreficint opened this issue Dec 24, 2021 · 0 comments

Comments

@gregoreficint
Copy link
Contributor

gregoreficint commented Dec 24, 2021

If you trade a while in Binance, you might end up with some coins that have such low amount that they are below the minimum amount to be traded. Thus, Binance introduced the function "Convert Small Balance to BNB" some time ago that cleans up these coins and converts them into BNB. Thus, this function is very similar to the trade for coins with very low amount, however, the conversion is not done via the orderbook but in Binance internally. Recently, Binance added an API to get the history of your "DustLogs", which is there name for the "Convert Small Balance to BNB" functionality.

I added a method within the trade service to get the history of these conversions. Since they are not strictly trades and have a very different data structure I added a Binance specific methods with corresponding DTOs without trying to generalize this Binance specific functionality in the core of XChange.

Pull request is #4370.

gregoreficint added a commit to gregoreficint/XChange that referenced this issue Dec 24, 2021
…bblet) in Binance that gives you the history of your conversion results for small balances that are so small that they cannot be traded. See knowm#4371.
walec51 pushed a commit that referenced this issue Jan 13, 2022
…n. (#4370)

* Adds the new response "EGeneral:Too many requests" from Kraken to the base service. See #4369 (comment)

* Added new possibility to use the DustLog call (GET /sapi/v1/asset/dribblet) in Binance that gives you the history of your conversion results for small balances that are so small that they cannot be traded. See #4371.

* Implemented suggestions from @walec51.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant