Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoinbasePro] Change "after" param to String #4289

Open
piechu111 opened this issue Oct 13, 2021 · 0 comments
Open

[CoinbasePro] Change "after" param to String #4289

piechu111 opened this issue Oct 13, 2021 · 0 comments

Comments

@piechu111
Copy link
Contributor

There is a ledger method in CoinbasePro interface and it has a Integer startingOrderId parameter. I think it should be a String because in some case orderId is greater then maxiumum value of Integer. Additionally, CoinbasePro documentation says that this parameter should be a String -> https://docs.cloud.coinbase.com/exchange/reference/exchangerestapi_getaccountledger

  @Path("accounts/{account_id}/ledger")
  @Consumes(MediaType.APPLICATION_JSON)
  List<Map<?, ?>> ledger(
      @HeaderParam("CB-ACCESS-KEY") String apiKey,
      @HeaderParam("CB-ACCESS-SIGN") ParamsDigest signer,
      @HeaderParam("CB-ACCESS-TIMESTAMP") long timestamp,
      @HeaderParam("CB-ACCESS-PASSPHRASE") String passphrase,
      @PathParam("account_id") String accountId,
      @QueryParam("after") Integer startingOrderId)  //should be a String
      throws CoinbaseProException, IOException;

What do you think about this change? Please consider it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant