Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for querying solana RPC #4096

Closed
douggie opened this issue Jun 2, 2021 · 10 comments
Closed

Add support for querying solana RPC #4096

douggie opened this issue Jun 2, 2021 · 10 comments

Comments

@douggie
Copy link
Collaborator

douggie commented Jun 2, 2021

Having programmatic access to various block chains proves useful (i.e. bitcoincore), especially to retrieve data which is then uses to then place orders on a dex or central exchange.

It would be very helpful, for me, and I am sure others, to be able to access various information from Solana via xchange.

The first implementation i would imagine the following methods exposed via an AccountService

Any objections for me to raise pull request for a new xchange/solana module that just implements the AccountService similarly to bitcoincore?

@earce
Copy link
Collaborator

earce commented Jun 2, 2021

This is really meant to query exchanges not blockchains.

Serum would be what you want to build querying around.

@earce earce closed this as completed Jun 2, 2021
@douggie
Copy link
Collaborator Author

douggie commented Jun 2, 2021

but we have examples of this in the project, such as bitcoincore.

@douggie
Copy link
Collaborator Author

douggie commented Jun 2, 2021

Will just be a pain to fork the project, maintain the solana rest interface and keep it up to date.

@earce
Copy link
Collaborator

earce commented Jun 2, 2021

I haven't been a maintainer when those modules were added @timmolter can opine more on this topic, but I don't see why conflate this project with blockchain explorer libraries, they are fundamentally different things.

@douggie
Copy link
Collaborator Author

douggie commented Jun 2, 2021

okey, and adding an account service to the serum project that queries solana adresses is a no go too?

@earce
Copy link
Collaborator

earce commented Jun 2, 2021

I think that would make sense because all Solana addresses can become addresses for exchange interaction. But I would be more curious about what that would turn into as more features are added.

I would leave it to @timmolter about where to draw the line, not sure if he cares about adding this functionality at all, this is just my opinion.

@douggie
Copy link
Collaborator Author

douggie commented Jun 2, 2021

all I am interested is is balances for a given public key, so seems ok to raise a PR for that within the serum module.

@douggie
Copy link
Collaborator Author

douggie commented Jun 2, 2021

i'll open another issue releated to just the serum changes.

@douggie
Copy link
Collaborator Author

douggie commented Jun 2, 2021

#4097 for the serum changes

@timmolter
Copy link
Member

Feel free to add this, as it's an addition to the serum DEX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants