Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lose data when rotate the phone #36

Open
Chou95 opened this issue Dec 29, 2022 · 2 comments
Open

Lose data when rotate the phone #36

Chou95 opened this issue Dec 29, 2022 · 2 comments

Comments

@Chou95
Copy link

Chou95 commented Dec 29, 2022

Hi~
When I use the app, I find some data loss issues. These issues occurs when I rotate the phone so that the previous input is lost, or the dialog disappears.
The snapshots are as followings (pairs of before rotation and after rotation), do you think these issues are bugs? Can they be fixed?

no.1 "Notes" loss

NO4-BEFORE
NO4-AFTER

no.2 "Project Name" editing loss

NO7-BEFORE
NO7-AFTER

no.3 dialog disappearance

NO10-BEFORE
NO10-AFTER

no.4 "total number of stitches" editing loss

NO11-BEFORE
NO11-AFTER

no.5 dialog disappearance

NO12-BEFORE
NO12-AFTER

@knirirr
Copy link
Owner

knirirr commented Jan 3, 2023

IIRC Android destroys the view and re-creates it on rotation. It's not easy to tell from the screenshots but I think that the "notes" field is one that is not saved during rotation.

Anyway, it is indeed possible to save fields on rotation. But, I have very little time indeed and so will find it difficult to get around to doing so. Anyone else would be welcome to submit a PR.

@Chou95
Copy link
Author

Chou95 commented Jan 30, 2023

IIRC Android destroys the view and re-creates it on rotation. It's not easy to tell from the screenshots but I think that the "notes" field is one that is not saved during rotation.

Anyway, it is indeed possible to save fields on rotation. But, I have very little time indeed and so will find it difficult to get around to doing so. Anyone else would be welcome to submit a PR.

Thanks for your reply!
Maybe I upload too many snapshots so that they looks messy (I have updated my comment right now, and the snapshots may looks clear). Actually, the snapshots display in pairs (one is captured before rotation and one is captured after rotation. Then, the following is a pair of snapshots about another data loss issue.)

I will try to fix these loss issues when I have enough time. If you could tell me the relevant source file, it is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants