This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Change KafkaChannel default replication factor and num partitions #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/cc @aliok |
Codecov Report
@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 75.23% 75.23%
=======================================
Files 123 123
Lines 5726 5726
=======================================
Hits 4308 4308
Misses 1196 1196
Partials 222 222 Continue to review full report at Codecov.
|
|
it looks good to me, but I leave it to @travis-minke-sap |
|
Thanks! |
pierDipi
deleted the
KNATIVE-1006-change-default-rf-and-num-partitions
branch
matzew
added a commit
to matzew/eventing-kafka
that referenced
this pull request
Feb 16, 2022
This reverts commit ce66b2e.
matzew
added a commit
to matzew/eventing-kafka
that referenced
this pull request
Feb 17, 2022
This reverts commit ce66b2e.
knative-prow-robot
pushed a commit
that referenced
this pull request
Feb 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006
The current defaults of setting partitions and replication factor to 1
aren't safe defaults for performance and durability.
This PR sets KafkaChannel default replication factor to 3 and
num partitions to 10.
Proposed Changes
Release Note