Skip to content

Commit 28a546b

Browse files
committed
Whitelist qe unknown properties on HTML elements.
1 parent b975d60 commit 28a546b

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

.eslintrc.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,13 @@ module.exports = {
1111
rules: {
1212
'no-prototype-builtins': 'off',
1313
'import/prefer-default-export': ['error'],
14-
'sort-imports': [2, {
15-
'ignoreDeclarationSort': true,
16-
}]
14+
'sort-imports': [
15+
2,
16+
{
17+
ignoreDeclarationSort: true,
18+
},
19+
],
20+
'react/no-unknown-property': ['error', { ignore: ['widget-type', 'widget-id', 'page-type', 'ouiaId'] }],
1721
},
1822
overrides: [
1923
{

packages/charts/src/Matrix/Matrix.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class Matrix extends Component {
7878
labels,
7979
} = this.props;
8080
return (
81-
<div identifier={this.props.identifier} className="ins-matrix-chart" widget-type="InsightsMatrix" widget-id={this.props.identifier}>
81+
<div className="ins-matrix-chart" widget-type="InsightsMatrix" widget-id={this.props.identifier}>
8282
<svg width={size} height={size} ref={(ref) => (this.ref = ref)}>
8383
<Axis size={gridSize} pad={pad} shift={shift}>
8484
{Object.values(data).map((oneSegment, key) => (

packages/charts/src/Matrix/__snapshots__/Matrix.test.js.snap

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
exports[`Pie component should render correctly 1`] = `
44
<div
55
className="ins-matrix-chart"
6-
identifier="test-matrix"
76
widget-id="test-matrix"
87
widget-type="InsightsMatrix"
98
>
@@ -219,7 +218,6 @@ exports[`Pie component should render correctly 1`] = `
219218
exports[`Pie component should render with config 1`] = `
220219
<div
221220
className="ins-matrix-chart"
222-
identifier="test-matrix"
223221
widget-id="test-matrix"
224222
widget-type="InsightsMatrix"
225223
>
@@ -435,7 +433,6 @@ exports[`Pie component should render with config 1`] = `
435433
exports[`Pie component should render with labels 1`] = `
436434
<div
437435
className="ins-matrix-chart"
438-
identifier="test-matrix"
439436
widget-id="test-matrix"
440437
widget-type="InsightsMatrix"
441438
>

0 commit comments

Comments
 (0)