Skip to content
This repository has been archived by the owner on Jan 21, 2025. It is now read-only.

Standardize argument names #10

Open
benesom opened this issue Nov 29, 2024 · 2 comments
Open

Standardize argument names #10

benesom opened this issue Nov 29, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@benesom
Copy link
Collaborator

benesom commented Nov 29, 2024

Do we prefer function argument name seperation with . or _? That is, response_call or response.call. We currently use both. For example, the ml_model R6 class uses predict.args and response.arg in its initialize method but the cate function uses response_model and propensity_model.

Is this something we would like to standardize?

@benesom benesom added the question Further information is requested label Nov 29, 2024
@kkholst
Copy link
Owner

kkholst commented Dec 2, 2024

We should standardize, and I vote for response.call. For the cate function this is now addressed in #12

@benesom
Copy link
Collaborator Author

benesom commented Dec 18, 2024

I also prefer dot seperation for argument names and snake case for functions and methods.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants