Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In zimit2 ZIMs, pages that do not have an overflow cannot swipe away the menu and nav bar #1266

Open
Jaifroid opened this issue Jul 10, 2024 · 4 comments
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Jul 10, 2024

I noticed this in the fas-military-medicine zimit2 ZIM. The landing page is too short to have an overflow / scrollbar. In other ZIM types (e.g. PhET) we can still swipe away the menu and navbar, which can otherwise obscure some content at the bottom of the page, but in this Zimit2 ZIM it's not working. This is a minor bug, but as we have code specifically to do this, it's strange that it's not working for this zimit2 ZIM.

@Jaifroid Jaifroid added the bug-non-critical For bugs that it would be nice to fix rather than critical to fix label Jul 10, 2024
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 10, 2024
@HUN-sp
Copy link

HUN-sp commented Aug 2, 2024

@audiodude I would like to work on this issue.

@Jaifroid
Copy link
Member Author

Jaifroid commented Aug 2, 2024

@HUN-sp Could you kindly explain what solution you have in mind for this issue? Please also take a look at CONTRIBUTING.md in the root to get an idea of what is involved in contributing to this repo. Many thanks!

@HUN-sp
Copy link

HUN-sp commented Aug 2, 2024 via email

@Jaifroid
Copy link
Member Author

Jaifroid commented Aug 2, 2024

Thank you @HUN-sp . It would be good to discuss your idea here before you start any serious work on it, because the swiping code is a bit intricate, and we would need an agreed approach. Currently the swiping away of menus relies on being able to scroll a page. A different solution is needed when the page won't scroll. Just so you know, this issue is not trivial IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix
Projects
None yet
Development

No branches or pull requests

2 participants