Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend popover support to new tabs or windows #1253

Open
Jaifroid opened this issue May 20, 2024 · 0 comments
Open

Extend popover support to new tabs or windows #1253

Jaifroid opened this issue May 20, 2024 · 0 comments

Comments

@Jaifroid
Copy link
Member

Jaifroid commented May 20, 2024

Once #1252 is finished, it might be a good idea to extend popover support to new windows and tabs opened by the app.

This is a bigger job, hence would need to be a separate PR. Up till now, we have not attempted to keep any reference to new containers, and so we can't track them in order to add the necessary event listeners. This is done in the PWA, but there is quite a lot of infrastructure associated with it there. It might be possible to do a "light" version here.

For info, tabs and windows are navigable in ServiceWorker mode, because the SW deals with the page's Fetch requests. But the SW doesn't have any access to the DOM, so cannot process links to add popovers.

@Jaifroid Jaifroid added this to the v4.2 milestone May 20, 2024
@Jaifroid Jaifroid changed the title Add popover support to new tabs or windows Extend popover support to new tabs or windows May 23, 2024
@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant