Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reading Zimit archives, images are inverted by dark theme #1210

Open
Jaifroid opened this issue Feb 12, 2024 · 3 comments
Open

When reading Zimit archives, images are inverted by dark theme #1210

Jaifroid opened this issue Feb 12, 2024 · 3 comments
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix user interface zimit Code relating to the support of Zimit-style archives
Milestone

Comments

@Jaifroid
Copy link
Member

For most OpenZIM types, the images are correctly re-inverted when applying the dark theme, but it's not working for Zimit 1 or Zimit 2 archives, which consequently look bad.

The proper solution is to introduce DarkReader (#908), but that's too complicated to do before v4.0.

@Jaifroid Jaifroid added user interface bug-non-critical For bugs that it would be nice to fix rather than critical to fix zimit Code relating to the support of Zimit-style archives labels Feb 12, 2024
@Jaifroid Jaifroid added this to the v4.1 milestone Feb 12, 2024
@AritraLeo
Copy link

I have seen this v4.1 milestone added to two of the issues so far, I am doubtful if I should start working on them specifically -
To run Unit testing under given memory range I think I can do that for given methods/funcs to test.
Please let me know !

@Jaifroid
Copy link
Member Author

@AritraLeo Are you specifically talking about this issue? I could easily bump this back to v4.1 if you were interested in working on it. But I'm not sure I understand your reference to Unit testing, which isn't part of this issue. Are you perhaps referring to a different issue?

@AritraLeo
Copy link

@AritraLeo Are you specifically talking about this issue? I could easily bump this back to v4.1 if you were interested in working on it. But I'm not sure I understand your reference to Unit testing, which isn't part of this issue. Are you perhaps referring to a different issue?

I apologize actually I saw the v4.1 in - #1205 as well so I thought about referencing both issues at once!

@Jaifroid Jaifroid modified the milestones: v4.2, v4.3 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix user interface zimit Code relating to the support of Zimit-style archives
Projects
None yet
Development

No branches or pull requests

2 participants