Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a UI test with keyboard selection of elements #1152

Open
Jaifroid opened this issue Nov 12, 2023 · 8 comments
Open

Include a UI test with keyboard selection of elements #1152

Jaifroid opened this issue Nov 12, 2023 · 8 comments

Comments

@Jaifroid
Copy link
Member

Following on from #1151, I think we need to incorporate (probably into the Ray Charles test, because it is currently less "crowded") a test that it is possible to select and use various UI elements (buttons) using the keyboard only. For example, something like using the tab key to cycle through UI elements and be sure that they are at least focused, if not actionable.

@Jaifroid
Copy link
Member Author

Jaifroid commented Nov 12, 2023

I'd probably suggest using tab key to get to the library button, testing that the library has opened, and then getting back with Shift-Tab to Configure, and activating that automatically. Slight complication is that if download.kiwix.org has opened, the action would have to be different (close the new browser tab, rather than cycle back to Configuration). I don't think it would be possible to test the file/folder selectors (because you can't actually "press" them, it's not possible to programme the native file selection dialogues, as they happen in the OS, not in Selenium).

@Jaifroid
Copy link
Member Author

@Rishabhg71 I've assigned you to this issue, but it's not at all an urgent issue. Just a "would be desirable". More important to work on the libzim integration and not let this one distract you, IMHO.

@skushagra9
Copy link

@Jaifroid, is there any critical issue which needs to be solved ??

@Rishabhg71
Copy link
Collaborator

@skushagra9 Take this issue if you want. If you solve this issue I think we can include it in v4.0

@Jaifroid
Copy link
Member Author

Agreed. @skushagra9, do you have any experience of testing with Selenium, or are you willing to read up about it? It's probably not a very easy first issue, but not hugely difficult either. The trickiest thing with testing scripts is that timings and timeouts in an asynchronous context are not always obvious.

@skushagra9
Copy link

Ok, I will definately give it a try

@Jaifroid Jaifroid assigned skushagra9 and unassigned Rishabhg71 Jan 19, 2024
@Jaifroid
Copy link
Member Author

Thanks @skushagra9. Please check CONTRIBUTING.md for how to set up the Repo. I suggest you only add this test to https://github.com/kiwix/kiwix-js/blob/main/tests/e2e/spec/legacy-ray_charles.e2e.spec.js, as we don't need it to run in both ZIMs. I suggest you add the test outlined in #1152 (comment). As you are a new contributor, you will have to notify one of us to get the tests to run when you add commits to your PR. They will run on GitHub, but won't run on Browser Stack initially, but the GitHub test will determine whether your code is working.

@skushagra9
Copy link

Ok Thanks

@Jaifroid Jaifroid modified the milestones: v4.0, v4.1 Feb 21, 2024
@Jaifroid Jaifroid modified the milestones: v4.1, v4.2 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants