Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resetting the app no longer empties the app cache #1136

Open
Jaifroid opened this issue Oct 21, 2023 · 2 comments
Open

Resetting the app no longer empties the app cache #1136

Jaifroid opened this issue Oct 21, 2023 · 2 comments
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix regression Broken things that used to work
Milestone
v4.2

Comments

@Jaifroid
Copy link
Member

It's not clear to me if this is an actual regression or whether it never worked properly. However, it is intended that a reset should be a full reset, including any caches, so this is definitely a bug.
@Jaifroid Jaifroid added regression Broken things that used to work bug-non-critical For bugs that it would be nice to fix rather than critical to fix labels Oct 21, 2023
@Jaifroid Jaifroid added this to the v4.0 milestone Oct 21, 2023
@Jaifroid Jaifroid modified the milestones: v3.11, v4.0 Nov 1, 2023
@Jaifroid
Copy link
Member Author

The assets cache is cleared on reset. It's the app cache that appears not to be, though it needs more thorough testing.

@Jaifroid
Copy link
Member Author

Jaifroid commented Nov 29, 2023 •
edited
Loading

Additionally, the new kiwix-zim database (IndexedDB) is not deleted when Reset App is called. Also, when #1173 is merged, we will need to deal with deleting the Replay DB.

@Jaifroid Jaifroid modified the milestones: v4.0, v4.1 Feb 21, 2024
@Jaifroid Jaifroid modified the milestones: v4.1, v4.2 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix regression Broken things that used to work
Projects
None yet
Milestone
v4.2
Development

No branches or pull requests
1 participant
@Jaifroid