Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implement search in tabs/history/bookmarks #1194

Open
kelson42 opened this issue Sep 2, 2024 · 2 comments
Open

New implement search in tabs/history/bookmarks #1194

kelson42 opened this issue Sep 2, 2024 · 2 comments
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Sep 2, 2024

Following #413

image

@kelson42 kelson42 added this to the 2.5.0 milestone Sep 2, 2024
@kelson42 kelson42 changed the title New implement search in tabs/bookmarks New implement search in tabs/history/bookmarks Sep 2, 2024
@kelson42 kelson42 modified the milestones: 2.5.0, 2.6.0 Sep 2, 2024
@kelson42
Copy link
Collaborator Author

See also #1189 (comment)

@ShaopengLin
Copy link
Collaborator

ShaopengLin commented Nov 7, 2024

@veloman-yunkan Working at #1237 makes me think using QTree/ListWidget might can make it easier to solve issue. Since QTree/ListWidget inherits from Views, it can be set as the view in QCompeleter. We can then simply add different suggestion views into the QTree/ListWidget.

The main problem would be how to correctly handle the different models, as well as dealing with QCompleter's selection and completion. I would expect this to be a huge change (again).

Also, I do not recommend replacing the existing view with QTreeWidget, simply due to endless search creates a very large list and QTreeWidget is known to be very bad at handling huge data amounts. (Originally why I decided to not use QTree/ListWidget.)

Just food for thought, in case the discussion we had back in #1189 doesn't hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants