Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External link is shown with black background when exporting a page #973

Open
HiroyasuNishiyama opened this issue Sep 9, 2024 · 5 comments
Assignees
Milestone

Comments

@HiroyasuNishiyama
Copy link
Contributor

HiroyasuNishiyama commented Sep 9, 2024

External link is shown with black background when exporting or printing a page as shown below.

スクリーンショット 2024-09-09 20 56 17

@kelson42 kelson42 self-assigned this Sep 9, 2024
@kelson42 kelson42 added this to the 3.6.0 milestone Sep 9, 2024
@kelson42
Copy link
Contributor

kelson42 commented Sep 9, 2024

@BPerlakiH Is that a problem with the content itself?

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Sep 9, 2024

@HiroyasuNishiyama Thank you for reporting this!

@kelson42 it does seems to be a content issue, there are some strange background properties set in css for the external link:
Screenshot 2024-09-10 at 00 47 21


when I disabled them, the PDF looks good:

Screenshot 2024-09-10 at 00 51 54

Also on non wiki content, the external links looks OK:
Screenshot 2024-09-10 at 00 53 13

@HiroyasuNishiyama
Copy link
Contributor Author

@BPerlakiH That CSS appears to be checking for SVG support and falling back to PNG. Please look at here.
In my opinion, this seems to be a bug of WKWebView.

@BPerlakiH
Copy link
Collaborator

I did some further investigation on this, and force-loaded the current Wikipedia content into the app (not from a ZIM file), and exported that to PDF, and that looks good. So I think it is purely a content issue:
wikipedia_export

@kelson42
Copy link
Contributor

I will move the issue to openzim/mwoffliner

@kelson42 kelson42 modified the milestones: 3.6.0, 3.7.0 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants