Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-assess / rollback JS fixes for videos #939

Open
BPerlakiH opened this issue Aug 18, 2024 · 6 comments
Open

Re-assess / rollback JS fixes for videos #939

BPerlakiH opened this issue Aug 18, 2024 · 6 comments
Assignees
Milestone

Comments

@BPerlakiH
Copy link
Collaborator

BPerlakiH commented Aug 18, 2024

Previously we were fixing reader side the following attributes in the content <video> html tag (for iPhones on iOS 17 only):

If there's a content side way to fix this, we should remove these hacks.

@benoit74
Copy link

benoit74 commented Sep 2, 2024

Is there any issue opened somewhere (in video.JS repository?) to track the fact that this is not working properly and should be fixed upstream? I don't mind to open the issue(s) if needed, but you probably have more context + these issues should be linked here so that we know when / if the issue is fixed upstream.

@rgaudin
Copy link
Member

rgaudin commented Sep 2, 2024

It's not a video.js bug ; see #916 (comment)

@benoit74
Copy link

benoit74 commented Sep 2, 2024

These issues could be "worked-around" at video.JS level because all video.JS users with an iPhone 17 have the problem.

Video.JS could probably detect that condition and remove the poster / add the playsinline ; or do I miss something?

@rgaudin
Copy link
Member

rgaudin commented Sep 2, 2024

Possibly, I think all the selection criteria are available in User-Agent and video format

Here's my UA in Kiwix 3.5.1 on macOS 14.6.1 for instance

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko)

Same on Safari

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.6 Safari/605.1.15

Now on affected iPhone

Mozilla/5.0 (iPhone; CPU iPhone OS 17_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148

And on Safari

Mozilla/5.0 (iPhone; CPU iPhone OS 17_5_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Mobile/15E148 Safari/604.1

@kelson42
Copy link
Contributor

@benoit74 I would like to move this issue in openzim/youtube or openzim/python-scraperlib. Is that OK for you?

@benoit74
Copy link

This problem is specific to apple platforms, so I don't think it really helps to move the issue.

The real problem is in these apple platforms / readers, the scraper is producing valid HTML5 code, only apple platforms are not capable to process it correctly.

And once problem is solved in video.JS, we still need to rollback JS fixes in kiwix-apple.

What is your intention by moving this issue? (if the goal is that I work on this issue rather than @BPerlakiH, then just assign me this issue, I don't mind to work on kiwix-apple issue ^^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants