-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iPad video subtitles pop-over is really small #915
Comments
@BPerlakiH The bug report lack of details. You mean you would like to have the popup box to have a bigger maximum height? What do you mean with native one? Could we have clear screenshots of what you get against what you expect? |
@kelson42 here is the comparison between using the provided videojs ui on the iPad, videojs:videojs_ui.mp4native:native_ui.mp4 |
So to sum up, this is specific only to iPad, and only when the video is not in full screen, it is really hard to browse those languages, and you need to be really accurate selecting, as it's less than half of a finger size. If the video is in full screen the subtitles can be changed without any problems. |
@benoit74 Your feedback would be welcome here about (1) "issue" assessment (2) how the solution could/should look like. |
If I get the issue correctly, then I think that this should be reported to videoJS since a generic solution would help all users. I don't have an iPad to test, but do we have the same issue on https://videojs.com/advanced?video=bipbop-advanced? |
And don't we have the same issue on all small touch screens? (e.g. on my Android phone, it is not easy to be sure to spot proper language either) |
@benoit74 Probably! To me this is an enhancement to do at videojs level and if they can't using a custom CSS to apply in our scraper(s). Therefore I would propose to:
Does that sounds appropriate? |
Why youtube ? video.js is used in many scrapers, not only youtube. |
Once fixed in youtube scraper I will request to fix in other scrapers. One issue at a time. |
But this issue speaks about a problem in TED ... |
@benoit74 Oui, so move to |
All scrapers relying on video.js are probably impacted in the same manner indeed |
Assigning to @benoit74 as this is something which might be improved at scraper level. Moving to next milestone. |
I have opened videojs/video.js#8892 to start the discussion at video.js side. That been said, I don't get why once in fullscreen you have a kind of different player. I don't have the same behavior on Android in my browser or in the app. Is this something specific to kiwix-apple? |
The subtitles pop-over is really small (compared to the native one, which is disabled by video js).
The text was updated successfully, but these errors were encountered: