Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online library can not be retrieved #3991

Open
kelson42 opened this issue Sep 11, 2024 · 10 comments · Fixed by #3994
Open

Online library can not be retrieved #3991

kelson42 opened this issue Sep 11, 2024 · 10 comments · Fixed by #3994
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Collaborator

On Samsung tablet with Android14, newly, the online library can not be retrieved. The spinner keeps running...

Screenshot_20240911_073854_Kiwix

It should work obviously as I have plenty of bandwidth

@kelson42 kelson42 added this to the 3.12.0 milestone Sep 11, 2024
@kelson42 kelson42 changed the title Online library and not be retrieved Online library can not be retrieved Sep 11, 2024
@Popolechien
Copy link
Member

I confirm having the same issue on Nothing Phone (2), also running android 14

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz This the current TOP priomissue. The PRshould include:

  • The fix
  • A proper automated test

@kelson42 kelson42 removed the question label Sep 11, 2024
@MohitMaliFtechiz
Copy link
Collaborator

@kelson42, @Popolechien I have checked it and the online library showing on the tablet.

Screenshot from 2024-09-12 11-26-08

It seems the issue is something else on your devices.

Can you please tell me if the spinner is showing infinitely? There is no error message showing on the screen after some time? e.g. "Swipe down for library".

Also, can you please provide the device logs? please try to open the OnlineFragment and wait for some time so that the application collects the errors from the logs, and then please attach the log.txt here. It would be helpful in debugging the problem.

@Popolechien
Copy link
Member

Spinner is infinitely showing, yes, and there was no error message. Swiped down (to refresh I assume?) and there was no change in behaviour (or to be correct, the screen did not "move", which is the normal Swipe down behaviour). Seems to be happening only on the playstore version however, I had installed the APK to test for #3993 and now have the library ¯_(ツ)_/¯
I'm adding the diagnostic report in case there's anything different between the playstore version (here) and the APK (in #3993)
Diagnostic Report.txt

@kelson42
Copy link
Collaborator Author

Spinner is infinitely showing, yes, and there was no error message. Swiped down (to refresh I assume?) and there was no change in behaviour (or to be correct, the screen did not "move", which is the normal Swipe down behaviour). Seems to be happening only on the playstore version however, I had installed the APK to test for #3993 and now have the library ¯_(ツ)_/¯ I'm adding the diagnostic report in case there's anything different between the playstore version (here) and the APK (in #3993) Diagnostic Report.txt

Same here for me. It is the very first time I experienced this bug myself but I have heard many time from users suffering from this. Here the preliminary things I would like to see implemented:

  • Please show the spinner in the middle of the of the screen (not at the top)
  • Below the spinner we should have something allowing ideally the user (and in case of problem the dev) to see the progress of the download AND/OR the current status. Therefore it can be a progress bar, but maybe better is a (small font) message like: reaching remote library, starting download of the online library, X% downloading library, remote library downloaded, parsing remote library.

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz Which versions of Kiwix are impacted by this bug?

@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 The versions after we introduced Android 14 have been impacted. Mainly the internal testing APK are impacted by this bug since we have not released the application in production after introducing the Android 14.

@kelson42
Copy link
Collaborator Author

The colorset is not OK in darkmode
Screenshot_20240919_195658_Kiwix

Before coding place explain why this does not work out of the box with default dark mode colorset of Android.

@kelson42 kelson42 reopened this Sep 19, 2024
@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 Here we have used the mine_shaft_gray900 for text which is not in the night-color.xml that's why it is showing a black color on the text in this dialog. At the runtime, it picks the color from night-color.xmlorcolor.xml` based on the theme, and if the matched configuration property is not found then it shows the default file's color. Just like the string file(when there is a translation available in the current language then it shows the translated language other it shows the default text which is present in the English version).

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz Please make a PR and ensure we use everywhere Android standard colors so we never run again in this kind of problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants