Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure pathTest.cpp <local@> <!> <local> #301

Open
Thermi opened this issue Mar 10, 2024 · 1 comment
Open

Test failure pathTest.cpp <local@> <!> <local> #301

Thermi opened this issue Mar 10, 2024 · 1 comment

Comments

@Thermi
Copy link

Thermi commented Mar 10, 2024

With commit d03ad5f on musl libc

[599/599] Linking CXX executable build/bin/misc_importanceHelperTest
...........................................................................................................................................
...........................................................................................................................................
...................................F.......................................................................................................
.....................................................
                                                                     
                                                                     
!!!FAILURES!!!                                                       
Test Results:                                                        
Run:  469   Failures: 1   Errors: 0                                  
                                                                     
                                                                     
1) test: pathTest::testGenerate (F) line: 88 /home/buildozer/aports/testing/libvmime/src/vmime-d03ad5f0f6d3b2d54009ccdc7d1f7670218b263c/tes
ts/parser/pathTest.cpp                                               
equality assertion failed                                                                                                                  
- Expected: <local@>                                                 
- Actual  : <local>
- 2
@jengelh
Copy link
Contributor

jengelh commented May 21, 2024

Duplicate of #294

jengelh added a commit to jengelh/vmime that referenced this issue Jun 11, 2024
As per RFC 5322, an email address must always have a @.
As per RFC 5321, a path is like an email address (always @),
with "" (<>) being the only other special value.

Fixes kisli#294, kisli#301.
jengelh added a commit to jengelh/vmime that referenced this issue Jun 11, 2024
Partially revert v0.9.2-183-g9b65b4de.

As per RFC 5322, an email address must always have a @.
As per RFC 5321, a path is like an email address (always @),
with "" (<>) being the only other special value.

Fixes kisli#294, kisli#301.
jengelh added a commit to jengelh/vmime that referenced this issue Jun 11, 2024
Partially revert v0.9.2-183-g9b65b4de.

As per RFC 5322 §3.4.1, an email address must always have a @.
As per RFC 5321 §4.1.2, a path is similar to an email address (always
@), with "" (<>) being the only other special value.

Fixes kisli#294, kisli#301.
jengelh added a commit to jengelh/vmime that referenced this issue Jun 11, 2024
As per RFC 5322, an email address must always have a @.
As per RFC 5321, a path is like an email address (always @),
with "" (<>) being the only other special value.

Fixes kisli#294, kisli#301.
vincent-richard pushed a commit that referenced this issue Jun 11, 2024
* Fix a test failure in testNewFromString

Fixes an oversight in d296c2d.

* Fix a test failure in pathTest::testGenerate

Partially revert v0.9.2-183-g9b65b4de.

As per RFC 5322 §3.4.1, an email address must always have a @.
As per RFC 5321 §4.1.2, a path is similar to an email address (always
@), with "" (<>) being the only other special value.

Fixes #294, #301.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants