Subtrees disappear

[acalcino]

Hello,
I have been using Numbat for a while but recently did a reinstall. Since then my results seem to be a bit off and I noticed in the stderr I get this issue:

running hclust...
! # Invaild edge matrix for . A <tbl_df> is returned.
! # Invaild edge matrix for . A <tbl_df> is returned.

I googled it and it looks like an issue with tidytree which according to this:

https://support.bioconductor.org/p/9153297/#9153321

Can be fixed by reverting back to v0.4.2 however when I do this, I upset numbat because it wants v0.4.5. I also noticed this issue in the output presented in issue #141 but it wasn't spoken about.

[teng-gao]

Thanks for reporting this. Maybe it's an object conversion problem between phylo and tidytree with the newer version. How do the results look different?

[acalcino]

Here's an example. The first plot (bulk_clones_final) was made before I did the reinstall and its beautiful (numbat is awesome btw!). The second was created using the exact same parameters but it gave this error I mentioned and you can see that it fails to find any of the previous cnvs.

You can see too that the number of cells in the second one is substantially lower than the first even though they both started with the same inputs.

[teng-gao]

Hi @acalcino ,

Thanks. I indeed see the same warning message "! # Invaild edge matrix for . A <tbl_df> is returned." when I upgrade to tidytree v0.4.5. However my results are the same when running on test cases. Would you share your input data via email so I can take a look?

Thanks,
Teng

[teng-gao]

Also, does this happen on all your samples or just one?

[acalcino]

Hello again,
Sorry for the late reply. I was away for a conference for a week, then we got hit by a cyclone, then the city flooded and now the highways to the uni campus are closed due to damage so I've been 'working from home' with two kids and torrential rain outside.

Anyway, I've only tried a before and after on that one sample but I do get that error every time I try and run the new version of Numbat. The samples I processed with the new Numbat all gave strange/unexpected results but as I don't have a control for them, I can't say for sure if this is related to the upgrade or whether its related to the samples themselves.

[teng-gao]

Hi @acalcino,

Wow, hope you and the family are ok.

What you describe indeed sounds abnormal. Let me know if you’re ok with sharing the input data for one of these examples privately (you can use my email [email protected]) so that I can debug this.

[teng-gao]

The invalid edge matrix warning is fixed in 7e936c3
The actual difference in results is actually caused by an incompatibility of igraph 2.0.x with tidygraph 1.3.1 .. see thomasp85/tidygraph#190
A fix was introduced in Numbat v1.4.0