Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Change [Reflect the expected result] to [Reflect the positive result] #89

Open
henriq-88 opened this issue Mar 14, 2023 · 0 comments
Open

Suggestion: Change [Reflect the expected result] to [Reflect the positive result] #89

henriq-88 opened this issue Mar 14, 2023 · 0 comments

Comments

@henriq-88
Copy link

When it comes to booleans, instead of Reflect the expected result, I would suggest to use the positive result for the name.

E.g. instead of isDisabled I would use isEnabled.

This avoids mental overhead of having to think about:

  • negating negative variables (e.g. !isDisabled = not not enabled = enabled)
  • which boolean state is expected. (For example, is a button really expected to be disabled?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@henriq-88