Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Instance Field in the Workload and App Spec #297

Closed
thschue opened this issue Nov 3, 2022 · 3 comments
Closed

Introduce Instance Field in the Workload and App Spec #297

thschue opened this issue Nov 3, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@thschue
Copy link
Contributor

thschue commented Nov 3, 2022

Synopsis:
To differentiate between multiple environments/instances/stages of an application, there needs to be something that helps distinguish them.

Therefore, I propose an introduction of an additional field in the workload and application spec ("instance") that could contain such information. When dealing with workloads, this information should be passed over as annotation (keptn.sh/instance or app.kubernetes.io/instance), whereby the keptn label takes precedence over the Kubernetes label, and the namespace name can be taken as a fallback. In applications, this can be set explicitly, if not set, we should fallback to the namespace in the ApplicationVersion.

@thschue thschue added this to the 1.0.x milestone Nov 3, 2022
@grabnerandi
Copy link
Member

Hi. Could you give an example on the instance? Would this be used to e.g: distinguish blue/green or canary vs main?

@thschue
Copy link
Contributor Author

thschue commented Nov 4, 2022

For example, you might have the same application in a dev, hardening or production environment, and all of them are reporting to the same monitoring instance. The instance field should help you differentiate the metrics and traces per environment.

I didn't think of blue-green deployments when writing this issue, but this might help to distinguish between the blue and green environments. I think this is a thing we can follow up on, great idea!

@thschue thschue added the enhancement New feature or request label Nov 11, 2022
@thschue
Copy link
Contributor Author

thschue commented Mar 3, 2023

I think we should rethink this issue when dealing with keptn/enhancement-proposals#90.

Therefore, closing this issue for the moment.

@thschue thschue closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants