Add Timezone parameter for evaluations

[pcjeffmac]

Feature Request

Need to pass in the timezone to allow timezones to match customers configuration with jenkins and keptn.

References

These features need a timezone,

markEvaluationStartTime()
sendStartEvaluationEvent()

If you think about adding a timezone option to the getNow.

def defineTZVariable(timezone) {
    if (timezone == null || timezone == "") {
      // use to set default timezone
      timezone = "UTC"     
    } else {
   	  timezone = timezone
    }
    def zid = ZoneId.of(timezone)
    echo "ZID: ${zid}"
    return zid
}

Then something like this,

def getNow() {
    // get timezone.
    def keptnInit = keptnLoadFromInit(args)
    String timezone = keptnInit['timezone']
    zid = defineTZVariable(timezone)
    // return java.time.LocalDateTime.now() 
    return java.time.Instant.now(zid)
}

You can also see this to use a timezone parameter,

def markEvaluationStartTime(timezone) {
    // get timezone.     
    zid = defineTZVariable(timezone)
    //def startTime = getNow().toString()       
    def LocalDateTime starttimelocal = LocalDateTime.now(zid)       
    // format time
    startTime = timestampFormatter(starttimelocal)

This in turn is basically adding a timezone to the timeformatter.

Thanks,
Jeff

[christian-kreuzberger-dtx]

Hi,

as far as I understand, getNow (which is currently implemented as return java.time.Instant.now().truncatedTo( ChronoUnit.MILLIS )) always returns the time in UTC, which is what Keptn accepts and uses by default.

What is the benefit of matching the timezone of the Jenkins installation, other than having the same string representation of the date time object?