Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keptnInit should list should handle missing parameters with a better granularity #52

Open
2 tasks
christian-kreuzberger-dtx opened this issue Nov 8, 2021 · 0 comments
Labels
type:feature New feature or request that provides value to the stakeholders/end-users

Comments

@christian-kreuzberger-dtx
Copy link
Contributor

When using

    def project = "nodejs-example"
    def service = "hello-service"
    def firststage = "dev"
...
        // Initialize the Keptn Project - ensures the Keptn Project is created with the passed shipyard
        keptn.keptnInit project:"${project}", service:"${service}", stage:"${firststage}", monitoring: "dynatrace", shipyard: ".keptn/shipyard.yaml"

I get the following error:

ERROR: keptnInit requires project, stage, service, keptn_endpoint, keptn_bridge and keptn_api_token to be set. These values cant be empty!

This error message is not very helpful. I propose to change this to

Definition of Done

  • Error message for missing parameters is displayed per missing parameter
  • missing configuration for keptn_endpoint, keptn_bridge and keptn_api_token shows a message indicating that environment variables / secrets should be configured (as shown in https://github.com/keptn-sandbox/keptn-jenkins-library#usage )
@christian-kreuzberger-dtx christian-kreuzberger-dtx added the type:feature New feature or request that provides value to the stakeholders/end-users label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or request that provides value to the stakeholders/end-users
Projects
None yet
Development

No branches or pull requests

1 participant