sendStartEvaluationEvent evaluates 0 as a negative number, incorrectly

[popecruzdt]

sendStartEvaluationEvent evaluates 0 as a negative number

Environment

• keptn-jenkins-library version: 6.1.0
• Keptn Version (keptn version): 16.X (although it shouldn't be relevant)
• Kubernetes Cloud Provider (e.g., GKE, AKS): N/A
• Kubernetes version (kubectl version): N/A
• Client OS (e.g., Linux, macOS, Windows): N/A
• Client Browser: N/A

Affected Component
keptn-jenkins-library only

To Reproduce
Within Jenkins pipeline, call sendStartEvaluationEvent and pass argument(s) startime or endtime with a value of 0.

def keptnContext = keptn.sendStartEvaluationEvent starttime:"600", endtime:"0"

Results in a failure and the output of:

echo "No negative numbers allowed for endtime!"

The issue is with these code blocks:

591: if (seconds > 0) {

601: if (seconds > 0) {

The operator should be seconds >= 0 so that it includes 0, as 0 is neither positive nor negative, and a valid parameter for this function.

Expected behavior
Treat 0 as a valid parameter for this function.

Current behavior
Does not treat 0 as a valid parameter for this function.

Screenshots
N/A

Additional context
N/A