Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo and fix the display name of the datadog-service integration in ArtifactHub #76

Open
3 tasks
vadasambar opened this issue Sep 23, 2022 · 4 comments · Fixed by keptn-contrib/artifacthub#186
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vadasambar
Copy link
Collaborator

vadasambar commented Sep 23, 2022

Problem statement.
Right now, if you search for datadog-service on ArtifactHub, you can see that datadog does not have a logo and the display name shows up as datadog-service instead of Datadog Service
image
Here's how Prometheus Service looks like:
image

Describe the solution you'd like

  1. Fix the displayName parameter for all versions of datadog-service in the keptn artifacthub repo here
  2. Use the following logo from https://www.datadoghq.com/about/resources/
    image
    You will have to add a logoUrl parameter in the artifacthub-pkg.yml (for example check this in Prometheus Service). Datadog does not have a logo Url you can use like Prometheus Service. We will have to download the logo, add it under images/ (<- create a new folder here) and use the link like this

TODO

  • Raise a PR with the above change
  • Ask for review in #keptn-integrations channel (mention @vadasambar so that he can help you out in case of problems)
  • Get the PR reviewed (note: you probably won't have the permission to merge the PR in https://github.com/keptn-contrib/artifacthub repo. Ask the reviewer to merge the PR)
  • DONE
@vadasambar
Copy link
Collaborator Author

Re-opened because the changes merged in the PR above have not been reflected yet
image

@tarangverma
Copy link
Contributor

can i take up this issue...

@vadasambar
Copy link
Collaborator Author

Assigned you @tarangverma .

@tarangverma
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants