Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed keptn versions < 0.18.x #90

Closed
wants to merge 1 commit into from
Closed

Removed keptn versions < 0.18.x #90

wants to merge 1 commit into from

Conversation

tarangverma
Copy link
Contributor

@tarangverma tarangverma commented Oct 1, 2022

Fixes #71

Removed keptn versions 0.16.x , 0.17.x from workflows/integration-tests.yaml to avoid the overflow to fail.

Signed-off-by: Tarang Verma [email protected]

@vadasambar
Copy link
Collaborator

@tarangverma thank you for the PR. We follow a particular commit style detailed here (ignore the Scopes part). Example commit messages. We also follow a similar style for PR titles (check this)

Can you fix your commit according to the style guide above?

You can fix the commit message using

git commit --amend
git push --force-with-lease

@vadasambar
Copy link
Collaborator

I also see you haven't done second and the third TODO mentioned in the original issue.
image
Can you do them 🙏

@vadasambar
Copy link
Collaborator

Re-request the review once you are done with the changes.

@tarangverma
Copy link
Contributor Author

Thank you
I will re-request the review after these changes.

@tarangverma tarangverma closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests fail for keptn version < 0.18.x (expected) and create a Github issues
2 participants