Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify compatibility with Keptn 0.20 baseline that will become Keptn 1..0 LTS #110

Open
2 of 4 tasks
Tracked by #105
vadasambar opened this issue Oct 12, 2022 · 11 comments
Open
2 of 4 tasks
Tracked by #105
Labels
good first issue Good for newcomers upgrade

Comments

@vadasambar
Copy link
Collaborator

vadasambar commented Oct 12, 2022

Problem

We want to make sure that datadog-service works well with 0.20 version of Keptn since this version is going to be the baseline for Keptn 1.0 LTS

TODO

  • add 0.20 in the integration tests here
  • run the integration tests manually from here
    image
  • see if the integration tests pass (note the results and screenshots in this issue)
  • create new Github issues or fix any issues that occur in the integration tests run
@shivam-Purohit
Copy link

Hey @vadasambar Can I take on this issue , I have little to no knowledge but I can try with bit of guidance.

@vadasambar
Copy link
Collaborator Author

Keptn 0.20 is not released yet so we won't be able to work on this yet.
image
https://github.com/keptn/keptn/releases

@vadasambar
Copy link
Collaborator Author

Keptn 0.20-next.0 is out

image

https://github.com/keptn/keptn/releases/tag/0.20.0-next.0

@vadasambar
Copy link
Collaborator Author

This ticket is up for grabs now if you are interested @shivam-Purohit (or if anyone else is interested)

@shivam-Purohit
Copy link

shivam-Purohit commented Dec 5, 2022

yeah sure I am on it .
Do I need to just add the 0 .20.0 in the keptn version or any more changes in the code base that I have very slit idea only.
After that I try to run the integration tests again and then make a pr?
update : missing charts for 0.20.0

@vadasambar
Copy link
Collaborator Author

Do I need to just add the 0 .20.0 in the keptn version or any more changes in the code base that I have very slit idea only.
After that I try to run the integration tests again and then make a pr?

This is what we have to do.

update : missing charts for 0.20.0

Helm treats 0.20.0-next.0 as a development version.

suraj@suraj:~/sandbox/suraj1$ helm search repo keptn/keptn --versions 
NAME       	CHART VERSION	APP VERSION	DESCRIPTION                                      
keptn/keptn	0.19.3       	0.19.3     	Cloud-native application life-cycle orchestration
keptn/keptn	0.19.2       	0.19.2     	Cloud-native application life-cycle orchestration
keptn/keptn	0.19.1       	0.19.1     	Cloud-native application life-cycle orchestration
...

^ you can't see it as a normal version but if you add --devel (read: development) flag, you can see it:

suraj@suraj:~/sandbox/suraj1$ helm search repo keptn/keptn --versions --devel
NAME       	CHART VERSION	APP VERSION  	DESCRIPTION                                      
keptn/keptn	0.20.0-next.0	0.20.0-next.0	Cloud-native application life-cycle orchestration
keptn/keptn	0.19.3       	0.19.3       	Cloud-native application life-cycle orchestration
keptn/keptn	0.19.2       	0.19.2       	Cloud-native application life-cycle orchestration
keptn/keptn	0.19.1       	0.19.1       	Cloud-native application life-cycle orchestration
...

@vadasambar
Copy link
Collaborator Author

vadasambar commented Dec 6, 2022

We use keptn-sandbox/action-install-keptn github action in the integration tests to install Keptn but it doesn't seem to support the --devel flag.

I can think of 2 options here:

  1. Make an upstream contribution to keptn-sandbox/action-install-keptn to support development versions
  2. Wait until we have 0.20.0 version of Keptn

For 1, I think we just need to add --devel flag on this line. As for 2, we might have to talk with the community. We want to get datadog-service up to speed with the 0.20.0-next.0 version because 0.20.0 is going to be created out of 0.20.0-next.0.

@vadasambar
Copy link
Collaborator Author

If you face any issues, feel free to reach out to me on Keptn slack (same username: @vadasambar)

@vadasambar
Copy link
Collaborator Author

vadasambar commented Dec 12, 2022

I have created a patched version of keptn-sandbox/action-install-keptn to test with 0.20.0-next.0 version for now
https://github.com/vadasambar/action-install-keptn/releases/tag/v4.0.0-patch-vadasambar

Commit in datadog-service. This is a temporary measure until Shivam's PR here gets merged

@vadasambar
Copy link
Collaborator Author

Kicked off integration test for 0.20.0-next.0
https://github.com/keptn-sandbox/datadog-service/actions/runs/3673057066
image

@vadasambar
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers upgrade
Projects
None yet
Development

No branches or pull requests

2 participants