Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Github Action for checking image paths #130

Open
TannerGilbert opened this issue May 15, 2022 · 4 comments
Open

Github Action for checking image paths #130

TannerGilbert opened this issue May 15, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@TannerGilbert
Copy link
Member

Currently, it can be hard to get the image path inside the README.md, and artifacthub-pkg.yml correct as URLs need to be used, and they can't be checked for correctness as they only start existing after merging into main. Therefore we should create an action that checks the URLs and maybe also can be executed manually.

@TannerGilbert TannerGilbert added the enhancement New feature or request label May 15, 2022
@agardnerIT
Copy link
Contributor

The other issue right now is that when writing the readme and artifacthub files, any local previews do not work for the same reason you point out above.

If possible I’d like to see the action or automation do the opposite: allow users to write relative paths locally which are then adjusted to the full urls when the pr is merged. That way, both production is protected from relative urls and local previews work.

@TannerGilbert
Copy link
Member Author

@agardnerIT I like the idea. @christian-kreuzberger-dtx what do you think about this?

@christian-kreuzberger-dtx
Copy link
Contributor

Not sure about that. Do we have any idea how other artifacthub repositories handle that? Clearly they would have the same problem, right?

@TannerGilbert
Copy link
Member Author

@christian-kreuzberger-dtx I just looked at some other repositories implementing AH integrations, but most of them don't have any automation. So I'll ask the Artifacthub team directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants