Problem
tests/mint_authorization_integration.rs contains 30 panic-prone calls (unwrap, expect, or panic!).
Evidence
tests/mint_authorization_integration.rs:44 — let url = std::env::var("DATABASE_URL").expect("DATABASE_URL required");tests/mint_authorization_integration.rs:45 — PgPool::connect(&url).await.expect("db pool")tests/mint_authorization_integration.rs:50 — Arc::new(StellarClient::new(config).expect("stellar client"))tests/mint_authorization_integration.rs:68 — let bytes = hex::decode(tx_hash_hex).unwrap();tests/mint_authorization_integration.rs:89 — .expect("seed reserve verification");
Proposed fix
Replace non-essential unwrap/expect usages with typed error propagation and contextual logging. Keep explicit panics only where unrecoverable invariants are well-documented.
Acceptance criteria
- All avoidable panic-prone calls in this file are removed or justified with comments/tests.
- Error paths return typed errors and preserve observability context.
- Existing tests pass (or new tests cover changed paths).
Problem
tests/mint_authorization_integration.rscontains 30 panic-prone calls (unwrap,expect, orpanic!).Evidence
tests/mint_authorization_integration.rs:44—let url = std::env::var("DATABASE_URL").expect("DATABASE_URL required");tests/mint_authorization_integration.rs:45—PgPool::connect(&url).await.expect("db pool")tests/mint_authorization_integration.rs:50—Arc::new(StellarClient::new(config).expect("stellar client"))tests/mint_authorization_integration.rs:68—let bytes = hex::decode(tx_hash_hex).unwrap();tests/mint_authorization_integration.rs:89—.expect("seed reserve verification");Proposed fix
Replace non-essential
unwrap/expectusages with typed error propagation and contextual logging. Keep explicit panics only where unrecoverable invariants are well-documented.Acceptance criteria