[Codebase Audit] Reduce panic-prone calls in `src/kyc/tests.rs`

[kelly-musk]

Problem

src/kyc/tests.rs contains 35 panic-prone calls (unwrap, expect, or panic!).

Evidence

• src/kyc/tests.rs:69 — let amount = BigDecimal::from_str("500.00").unwrap();
• src/kyc/tests.rs:70 — let daily_used = BigDecimal::from_str("1000.00").unwrap();
• src/kyc/tests.rs:71 — let monthly_used = BigDecimal::from_str("10000.00").unwrap();
• src/kyc/tests.rs:78 — let amount = BigDecimal::from_str("2000.00").unwrap(); // Exceeds $1000 limit
• src/kyc/tests.rs:79 — let daily_used = BigDecimal::from_str("0.00").unwrap();

Proposed fix

Replace non-essential unwrap/expect usages with typed error propagation and contextual logging. Keep explicit panics only where unrecoverable invariants are well-documented.

Acceptance criteria

• All avoidable panic-prone calls in this file are removed or justified with comments/tests.
• Error paths return typed errors and preserve observability context.
• Existing tests pass (or new tests cover changed paths).

[olufunsoolutayo]

@olufunsoolutayo has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hello maintainer. I would love to resolve this issue in no time. Pls assign to me. Thank you

ℹ️ Repo Maintainers: To accept this application, review their application or assign @olufunsoolutayo to this issue.

[alexatsejames-alt]

@alexatsejames-alt has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi can you please assign these issue to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @alexatsejames-alt to this issue.

[drips-wave]

Congratulations, @alexatsejames-alt! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @alexatsejames-alt: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[Meemlahsabi]

@Meemlahsabi has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi there! This issue immediately caught my attention because it closely matches my technical experience and interests. I’m confident in my ability to implement the required functionality with precision while maintaining code quality and consistency throughout the project. I’d love the opportunity to contribute by working on this task.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Meemlahsabi to this issue.

[owohdora-stack]

@owohdora-stack has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi maintainer am active to resolve this issue, have gone through it and will carry out the task perfectly and diligently
Kindly assign this to me thanks

ℹ️ Repo Maintainers: To accept this application, review their application or assign @owohdora-stack to this issue.

[Abba073]

@Abba073 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi maintainer, i would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Abba073 to this issue.

[Saboleee]

@Saboleee has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I would love to work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Saboleee to this issue.

[Chronos-III]

@Chronos-III has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

hi team kindly assign me i can work on this issue am a solid backend dev

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Chronos-III to this issue.