Fix ESLint warnings in login.spec.ts

[kelleyglenn]

Description

The e2e/tests/auth/login.spec.ts file has 4 ESLint warnings from the Playwright plugin:

12:5   warning  Avoid having conditionals in tests       playwright/no-conditional-in-test
13:13  warning  Unexpected use of page.waitForTimeout()  playwright/no-wait-for-timeout
27:5   warning  Avoid having conditionals in tests       playwright/no-conditional-in-test
28:13  warning  Unexpected use of page.waitForTimeout()  playwright/no-wait-for-timeout

Why this matters

• Conditionals in tests: Make tests non-deterministic and harder to debug
• waitForTimeout(): Brittle timing-based waits; prefer waiting for specific conditions

Suggested fix

Replace waitForTimeout() with proper Playwright waiting mechanisms:

• page.waitForSelector()
• page.waitForLoadState()
• expect().toBeVisible() with auto-waiting

Remove conditionals by either:

• Ensuring consistent test state via proper setup
• Splitting into separate test cases

[TheDerbiedOne]

I pulled the current default branch at 2de4d11 and re-ran lint.

npx eslint e2e/tests/auth/login.spec.ts reports no warnings for login.spec.ts now (so the playwright/no-conditional-in-test + playwright/no-wait-for-timeout warnings mentioned in this issue appear to be resolved already).
npm run lint does still show warnings in other files (mostly .skip() and a couple not.toBeVisible() style warnings). If you want, I can open a separate issue/PR for those, but I didn’t change anything here since issue #2 was specifically about login.spec.ts.

[TheDerbiedOne]

I pulled current main and re-ran ESLint locally.

• npx eslint e2e/tests/auth/login.spec.ts -> no output, exit 0 (no warnings/errors)
• npm run lint -> none in e2e/tests/auth/login.spec.ts

While I was there, I also fixed the 2 playwright/no-useless-not warnings (swap not.toBeVisible() -> toBeHidden()), which reduces the overall lint warnings count (optional diff below).

Evidence from my run:

• Full lint output: runs/2026-05-27_acctatlas-integration-tests_2_fix/lint-output.txt
• File-only lint output (empty): runs/2026-05-27_acctatlas-integration-tests_2_fix/eslint-login-output.txt
• Lint output after the tiny toBeHidden() cleanup: runs/2026-05-27_acctatlas-integration-tests_2_fix/lint-output-after.txt

This issue looks resolved on current HEAD; suggest closing (or updating the issue to target the remaining warnings elsewhere).

Optional patch (reduces 2 warnings; leaves the .skip() warnings untouched):

<paste from runs/2026-05-27_acctatlas-integration-tests_2_fix/lint-warnings-minor-fix.diff>