Skip to content

Swallowing exceptions in client callbacks #98

@masojus

Description

@masojus

When we call onSuccess()/onFailure on KeenCallback/KeenDetailedCallback we swallow any exceptions. It probably makes sense to not generate exceptions unless debug mode is turned on, if those exceptions were raised in the SDK, but if the exception was raised in client code, an argument could be made that clients would want to see that exception and fix it.

We should talk a bit more about this and decide what to do here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions