Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ropee deployment on kubernetes #12

Open
benoittoulme opened this issue Jun 24, 2020 · 1 comment
Open

ropee deployment on kubernetes #12

benoittoulme opened this issue Jun 24, 2020 · 1 comment

Comments

@benoittoulme
Copy link

Hi, thank you for your work on ropee!

We have ropee running in a kubernetes cluster, I do not know if you tried to do that before.
kubernetes requires a readiness / liveness probe, which needs to return 200 (or ropee will be killed by k8s)

We tried to use /metrics as probe, but that caused some issues, maybe because prometheus is using the same endpoint to collect metrics. So we implemented a dumb /health that... returns 200.

Have you ever tried ropee on k8s?
Do you expect /metrics to work as liveness probe call?
Do you have ideas about better healthchecks than just returning 200?

I can help with an upstream PR if you are interested.

@kebe7jun
Copy link
Owner

kebe7jun commented Jun 28, 2020

@benoittoulme Hi, I have ever deployed ropee on Kubernetes, but no liveness probe added.
It is a good idea to add a /healthz endpoint for liveness or readyness probe.
Looking forward for your PR. ; )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants