Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDL 2.0 compliance #21

Open
zkat opened this issue Feb 7, 2024 · 4 comments
Open

KDL 2.0 compliance #21

zkat opened this issue Feb 7, 2024 · 4 comments

Comments

@zkat
Copy link
Member

zkat commented Feb 7, 2024

KDL 2.0.0-draft.3 is now generally available (kdl-org/kdl#286), and with it, we've decided to encourage existing implementations to start working towards 2.0 support and send feedback and suggestions for anything you might run into, so I'm making this tracking issue. :)

@larsgw
Copy link
Collaborator

larsgw commented Feb 7, 2024

Chevrotain v11 (the parser lib) is ESM-only now, how do you feel about moving to ESM (or async import()) vs keeping it at v10 for now?

@larsgw
Copy link
Collaborator

larsgw commented Feb 7, 2024

There don't seem to be a great deal of other changes since v10 so I'd be fine with keeping that for now. https://chevrotain.io/docs/changes/CHANGELOG.html

@zkat
Copy link
Member Author

zkat commented Feb 7, 2024

I am, in general, in favor of ESM-ification, tbh. But if there's no big changes worth pulling in, compat is probably a better idea.

@larsgw
Copy link
Collaborator

larsgw commented Feb 8, 2024

Currently considering whether to just test for the DLCPs before parsing, or including them in the lexer (and complicating the token patterns in the process).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants