Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer certificate not verified with IMAP-STARTTLS? #163

Open
ccpp opened this issue May 10, 2019 · 4 comments
Open

Peer certificate not verified with IMAP-STARTTLS? #163

ccpp opened this issue May 10, 2019 · 4 comments

Comments

@ccpp
Copy link

ccpp commented May 10, 2019

Can you explain why you do not per default validate the IMAP peer certificate in STARTTLS mode?
To me this looks like a bad practice solution to SSL errors (as they are often found as "accepted answers" on stack overflow or similar.)

$this->setFlag('novalidate-cert');

@kartolo
Copy link
Owner

kartolo commented Jul 11, 2019

the Fetch library is coming from tedious/Fetch and is used as it is. See: https://github.com/tedious/Fetch/blob/master/src/Fetch/Server.php#L134

Do you see the necessity for the user to set the flag manually? See IMAP Flag.

@ccpp
Copy link
Author

ccpp commented Jul 12, 2019

Hi,
thank you for the hint, I did not see you are using hat library, see the upstream issue tedious/Fetch#218.

No, I do not see necessity for setting it manually, but I'd go a step ahead and re-set the validate-cert flag without question.
Then, for the case that connection establishment fails due to certificate validation, direct_mail should recommend adding peer (issuer) certificate for validation. That would be the way to solve these security issues without decreasing security.

@responseinformationsdesign
Copy link
Contributor

I think there should be a possibility to set such flags (/ssl/novalidate-cert f. e.) in the planner task.

@ccpp
Copy link
Author

ccpp commented May 16, 2020

@responseinformationsdesign that would be OK, but only when there is a note that this is highly insecure, and that there are better solutions to such issues, e.g. updating ca certificates on OS level. And, by default that flag should be off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants