Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing development documentation #1152

Open
kantord opened this issue Mar 6, 2021 · 7 comments
Open

Add missing development documentation #1152

kantord opened this issue Mar 6, 2021 · 7 comments
Labels
wontfix This will not be worked on

Comments

@kantord
Copy link
Owner

kantord commented Mar 6, 2021

  • Document where images come from
  • Document where sounds come from
  • Document previewing courses locally
  • Document list of Python packages
  • Document setting up Python packages
  • Document testing Python packages
  • Document Cypress testing
  • Document how to write new Gherkin tests
@stale
Copy link

stale bot commented Aug 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 3, 2021
@kantord kantord removed the wontfix This will not be worked on label Aug 4, 2021
@kantord kantord pinned this issue Aug 4, 2021
@stale
Copy link

stale bot commented Jan 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 1, 2022
@stale stale bot closed this as completed Jan 9, 2022
@kantord kantord reopened this Mar 4, 2022
@jdmaras
Copy link

jdmaras commented Mar 16, 2023

I was trying to work on documenting where the sounds come from but I was hoping for some clarification on what exactly I was doing.

Am I documenting what site created the sound?

@jowodo
Copy link

jowodo commented Mar 17, 2023

This seems related to these two open issues:

@kantord
Copy link
Owner Author

kantord commented Mar 18, 2023

yes, well, those are future plans for where the sound comes from. I think those should be in the documentation and the issues should be linked, because a lot of people are interested in this topic,

the current sound that exists is fetched by a TTS engine through an API, and that is also very important to be documented

I think the best place to start research could be this closed issue, that is already completed that the pull request where it was fixed is also linked there #1473

let me know if you need more help regarding this or anything

@Skivling
Copy link

@kantord
The existing development documentation does not work with the latest versions of the dependencies, such as yarn. The suggested commands do not exist, yarn web dev is now yarn run web-dev I believe. When going into the test language, it just redirects to a Hello World page with nothing on it.
It is also very unclear as to how to run the yaml loader and exporter on a yaml course, with many things just not working or referencing outdated things that don't work anymore. The shell scripts fail and return various errors as well.

Can you please update the documentation and make these testing tools work? Also document how to convert a yaml course to json just using the python tools (which haven't been updated for 2 years??).

I also tried the TDD python thing and did exactly everything it told me and got errors not accounted in it.

@Skivling
Copy link

Hang on. Does the yaml export to json just the course content, or is it formatted for how the web app likes it? In a different app (not python based), should I instead be parsing the yaml directly? I will probably read the python yaml-loader and figure out what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants