Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit falsy attributes from link(). #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kmonahan
Copy link

@kmonahan kmonahan commented Nov 7, 2022

Fixes issue where values of FALSE or NULL were passed through as strings instead of removing the attribute.

Example:

{% set link_attributes = {
    'class': link_classes,
    'aria-current': item.is_active ? 'page' : null,
  } %}
{{ link(item.title, item.url, link_attributes) }}

Before, resulted in aria-current="null". After, omits the aria-current attribute when the value is null.

Fixes issue where values of FALSE or NULL were passed through as strings instead of removing the attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant