Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metalsmith Watch Support #31

Open
fortes opened this issue Jun 20, 2017 · 3 comments
Open

Fix Metalsmith Watch Support #31

fortes opened this issue Jun 20, 2017 · 3 comments

Comments

@fortes
Copy link

fortes commented Jun 20, 2017

Thanks for this plugin, I have recently moved from metalsmith-in-place and metalsmith-layouts over to just metalsmith-jstransformer (run in two passes, one for markdown w/o layout and then the second w/ layouts).

Everything works great the first time, but if you're using metalsmith-watch and edit a file, the file will then lose layout on all subsequent builds until you kill the process and restart.

The repro is pretty simple, you can see it here in this gist: https://gist.github.com/fortes/eac83cfcc025e5f5afc4dd0c80e4741c

To run locally: git clone https://gist.github.com/eac83cfcc025e5f5afc4dd0c80e4741c.git repro and see the instructions in README.md

@RobLoach RobLoach changed the title Layouts not applied on second build when watching Fix Metalsmith Watch Support Jun 20, 2017
@RobLoach
Copy link
Contributor

You're right, and thank you for the nice testing platform for it.

Moved your repo over to #32 so that we can test it more thoroughly. Watch may forget the existance of the layouts, so it doesn't re-apply them on the second build.

@fortes
Copy link
Author

fortes commented Jun 30, 2017

Thanks for taking a look, let me know if there is anything I can do to help.

@RobLoach
Copy link
Contributor

Not sure where metalsmith-watch stores its cache. We may need to go into its inards and figure out what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants