Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melee attack with cantrip: Booming blade, 2nd damage -> add description #813

Open
InfernoIV opened this issue Jun 4, 2021 · 3 comments
Open
Labels
enhancement New feature or request unsure not sure if to be implemented

Comments

@InfernoIV
Copy link

Describe the bug
If you roll a weapon attack using booming blade, it shows 2 lines of damage:

  • Thunder (Booming Blade) Damage: x
  • Thunder (Booming Blade) Damage: y

Please add an description on which damage is which.
In the spell tab, it is described as:
"2d8 Damage
3d8 Damage
(Moving Target)"

To Reproduce
Steps to reproduce the behavior:

  1. Go to character sheet
  2. Click on weapon, to see details
  3. Click on Beyond20 logo behind "Booming Blade"
  4. See the rolls in chat, but without explanation

Expected behavior
I expect text to be added "(Moving Target)", as described in the spells.

Screenshots

image

image

image

Browser Info (please complete the following information):

  • Browser: Edge
  • Foundry Version: 0.8.6
  • Beyond20 Version: 2.4.3

Additional context
Link to the character sheet: ddb.ac/characters/26710121/6Ylpa2

@InfernoIV InfernoIV added the bug Something isn't working label Jun 4, 2021
@InfernoIV InfernoIV changed the title booming blade 2nd damage add description Cantrip with melee attack: Booming blade 2nd damage -> add description Jun 4, 2021
@InfernoIV InfernoIV changed the title Cantrip with melee attack: Booming blade 2nd damage -> add description Melee attack with cantrip: Booming blade, 2nd damage add description Jun 4, 2021
@InfernoIV InfernoIV changed the title Melee attack with cantrip: Booming blade, 2nd damage add description Melee attack with cantrip: Booming blade, 2nd damage -> add description Jun 4, 2021
@Aeristoka Aeristoka added unsure not sure if to be implemented enhancement New feature or request and removed bug Something isn't working labels Jun 4, 2021
@Aeristoka
Copy link
Collaborator

The issue here begins very swiftly to become the length of the message, at this point it would be:
Thunder (Booming Blade) (Moving Target) Damage:

Which might look ok (but not really at all) on FoundryVTT, and horrifying on Roll20 (huge user base).

In my opinion, this is one of those "The Player and the GM need to know the spell parts, and when they apply", not something for Beyond20 to do.

@kakaroto , your thoughts?

@kakaroto
Copy link
Owner

kakaroto commented Jun 6, 2021

Yeah, the reason I don't include that extra text is because it can be pretty long, making it unreadable, especially on Roll20, but even in Foundry or Discord, it becomes too much. While the "Moving target" is not so bad, there are other spells where you have a much more descriptive text, and already including the damage type + the spell it came from is making it large.

That being said, I'm not dismissing this entirely because it is a valid concern. Especially since the damage can be different and you may not want to hover on each to know what it applies to, but the damages should be respecting the same order, so you would know be able to know that the second thunder damage is the one for the moving target because that's how it appears in D&D Beyond.

Keeping the issue open, but with the unsure tag, to be evaluated later.
Thanks.

@kakaroto kakaroto added this to the Maybe some day milestone Jun 6, 2021
@InfernoIV
Copy link
Author

I don't know what the possibilities are, but I have 2 ideas:

  1. Add a tooltip on the damage roll describing the pre-requisites of the damage (a DC that must be passed, target has to move, etc.). This will make it look clean in Foundry, and if needed you can hover the mouse over the damage to see the pre-requisites. Not sure if that is possible though.

  2. Add the option "Damage long description" to Beyond20? In that way, (new) players can enable it to post the whole damage effect description (of every item, since it's a global option), and disable it when it's no longer needed.

Just some ideas, please let me know you thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unsure not sure if to be implemented
Projects
None yet
Development

No branches or pull requests

3 participants